[coreboot-gerrit] Change in coreboot[master]: fsp_broadwell_de: Add SMM code

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19145 )

Change subject: fsp_broadwell_de: Add SMM code
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/19145/2/src/soc/intel/fsp_broadwell_de/cpu.c
File src/soc/intel/fsp_broadwell_de/cpu.c:

PS2, Line 70: /* Now that all APs have been relocated as well as the BSP let SMIs
            : 	 * start flowing. */
use correct style for multi-line comment


https://review.coreboot.org/#/c/19145/2/src/soc/intel/fsp_broadwell_de/smi.c
File src/soc/intel/fsp_broadwell_de/smi.c:

PS2, Line 54: /* Clear all possible set smi status bits
            : 	 * before enabling SMIs.
            : 	 */
multi-line comment


PS2, Line 59: 	/* Enable SMI generation:
            : 	 *  - on SERIRQ-SMI (is always enabled)
            : 	 */
same as above


https://review.coreboot.org/#/c/19145/2/src/soc/intel/fsp_broadwell_de/smmrelocate.c
File src/soc/intel/fsp_broadwell_de/smmrelocate.c:

PS2, Line 59: 	/* The relocated handler runs with all CPUs concurrently. Therefore
            : 	 * stagger the entry points adjusting SMBASE downwards by save state
            : 	 * size * CPU num. */
multi-line comment style anywhere in this file


-- 
To view, visit https://review.coreboot.org/19145
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I461a14d411aedefdb0cb54ae43b91103a80a4f6a
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at gmail.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes