[coreboot-gerrit] Change in coreboot[master]: apollolake: Switch FADT to ACPI version 3.0

[Werner Zeh (Code Review)]

Werner Zeh has uploaded a new change for review. ( https://review.coreboot.org/19146 )

Change subject: apollolake: Switch FADT to ACPI version 3.0
......................................................................

apollolake: Switch FADT to ACPI version 3.0

The current implementation of the FADT structure is only ACPI 3.0 complaint.
Setting the version to ACPI 5.0 results in a corrupt FADT. Linux seems
to be able to deal with it but Windows 10 hangs in a really early stage
without any notification to the user.

If ACPI 5.0 is mandatory, the FADT structure needs to be adjusted to
match the specification.

Change-Id: I51c7a7a84d10283f5c2a8a2c57257d53bbdee7ed
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/soc/intel/apollolake/acpi.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/19146/1

diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index 9f57206..3dbd410 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -86,8 +86,8 @@
 {
 	const uint16_t pmbase = ACPI_PMIO_BASE;
 
-	/* Use ACPI 5.0 revision. */
-	fadt->header.revision = ACPI_FADT_REV_ACPI_5_0;
+	/* Use ACPI 3.0 revision. */
+	fadt->header.revision = ACPI_FADT_REV_ACPI_3_0;
 
 	fadt->sci_int = acpi_sci_irq();
 	fadt->smi_cmd = APM_CNT;

-- 
To view, visit https://review.coreboot.org/19146
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51c7a7a84d10283f5c2a8a2c57257d53bbdee7ed
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>