[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Set sdcard card detect (CD) host owner...

[Venkateswarlu V Vinjamuri (Code Review)]

Venkateswarlu V Vinjamuri has posted comments on this change. ( https://review.coreboot.org/18947 )

Change subject: soc/intel/apollolake: Set sdcard card detect (CD) host ownership
......................................................................


Patch Set 7:

(7 comments)

https://review.coreboot.org/#/c/18947/7/src/soc/intel/apollolake/acpi.c
File src/soc/intel/apollolake/acpi.c:

Line 196: 		gnvs->scdh = pad_off % 32;
> Why aren't you using the relative pad number directly? The ASL code is doin
Done


https://review.coreboot.org/#/c/18947/7/src/soc/intel/apollolake/acpi/gpiolib.asl
File src/soc/intel/apollolake/acpi/gpiolib.asl:

Line 18: 	Name (HSAD, 0) /* store HOSTSW_REG address */
> So the methods that read and write to this location are serialized, but the
Done


PS7, Line 74: GPIO offset
> pad relative to the community?
Done


PS7, Line 78: Or
> We should be Add'ing here.
Done


PS7, Line 86: ,4
> , 4
Done


Line 87: 		Store (Local0, HSAD)
> This method can't return a value?
Done


https://review.coreboot.org/#/c/18947/7/src/soc/intel/apollolake/acpi/scs.asl
File src/soc/intel/apollolake/acpi/scs.asl:

Line 131: 				\_SB.SHO (\SCDP, Local0)
> This sequence could use some comments.
Done


-- 
To view, visit https://review.coreboot.org/18947
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042a8762dc1f9cb73e6a24c1e7169c9746b2ee14
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar at intel.com>
Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes