[coreboot-gerrit] Change in coreboot[master]: amd/gardenia: OemPostParams is not a callout

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19141 )

Change subject: amd/gardenia: OemPostParams is not a callout
......................................................................


Patch Set 1:

(1 comment)

Yeah, that's a good move.  I'd make the commit message more verbose here and in https://review.coreboot.org/#/c/19140/1.  I don't mind making the change but didn't want to hijack your patches.

https://review.coreboot.org/#/c/19141/1//COMMIT_MSG
Commit Message:

PS1, Line 7: OemPostParams is not a callout
Maybe...

amd/gardenia: Relocate OemPostParams function

OemPostParams() is called from the wrapper and is not a callout from AGESA.  Move the function to a better location.


-- 
To view, visit https://review.coreboot.org/19141
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ad1cbf244501207af96e0ac415a5b80ced91052
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes