[coreboot-gerrit] Change in coreboot[master]: gru: Initialize I2C bus for ARC2C0608

Julius Werner (Code Review) gerrit at coreboot.org
Wed Apr 5 23:02:38 CEST 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/19105 )

Change subject: gru: Initialize I2C bus for ARC2C0608
......................................................................


Patch Set 2:

(1 comment)

LGTM, thanks!

https://review.coreboot.org/#/c/19105/2/src/mainboard/google/gru/mainboard.c
File src/mainboard/google/gru/mainboard.c:

Line 351: 	if (IS_ENABLED(CONFIG_BOARD_GOOGLE_GRU))
We'll eventually probably want to introduce another option here (e.g. CONFIG_GRU_HAS_ARCTICSAND_BACKLIGHT or something like that). But we can wait with that until we have another board that actually uses the Arctic Sand.]


-- 
To view, visit https://review.coreboot.org/19105
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6709159f5ed28ad0b62397d2ddb504dec55167
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list