[coreboot-gerrit] Change in coreboot[master]: soc/intel & sb/intel/*/acpi/*.asl: Change Device(TIMR) to De...

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Wed Apr 5 21:37:07 CEST 2017


HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/19138 )

Change subject: soc/intel & sb/intel/*/acpi/*.asl: Change Device(TIMR) to Device(TMR)
......................................................................


Patch Set 2:

> I think TIMR is the better name. Why unify at all?

Because using the same name for the same thing is better :)

What it will happen if the board.asl uses (TMR) and on it SB we have (TIMR)?

-- 
To view, visit https://review.coreboot.org/19138
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1435d55b35c022ea09a8a2c36257eb06d1ef72ed
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list