[coreboot-gerrit] Change in coreboot[master]: soc/intel & sb/intel/*/acpi/*.asl: Change Device(TIMR) to De...

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Wed Apr 5 20:37:16 CEST 2017


HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/19138 )

Change subject: soc/intel & sb/intel/*/acpi/*.asl: Change Device(TIMR) to Device(TMR)
......................................................................


Patch Set 2:

(1 comment)

for  Device (RTC) _ IO (Decode16, .... the length should be 0x02 , right ?

https://review.coreboot.org/#/c/19138/2/src/southbridge/intel/i82801gx/acpi/lpc.asl
File src/southbridge/intel/i82801gx/acpi/lpc.asl:

PS2, Line 183: 8
shouldn't be "2" ?


-- 
To view, visit https://review.coreboot.org/19138
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1435d55b35c022ea09a8a2c36257eb06d1ef72ed
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list