[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: using tpm irq to sync tpm transaction

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Apr 5 20:29:32 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19113 )

Change subject: drivers/spi/tpm: using tpm irq to sync tpm transaction
......................................................................


Patch Set 2:

> I can't help but think this is not the right way to go about doing this.

Yes, there are a few more things that need to be fixed in here. I will see if I can make this driver more similar to the I2C one.

-- 
To view, visit https://review.coreboot.org/19113
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib64107b17fb6e93dbe626ce92f3bc9da8b84784e
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list