[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add support for common GSPI controller

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19098 )

Change subject: soc/intel/common: Add support for common GSPI controller
......................................................................


Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/19098/9/src/soc/intel/common/block/gspi/gspi.c
File src/soc/intel/common/block/gspi/gspi.c:

Line 623: 	p->out = (const uint8_t *)dout;
> cast of dout of and din shouldn't be needed?
yes, that's right.


-- 
To view, visit https://review.coreboot.org/19098
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb91eba2c523be457fee8922c44fb500a9fa140
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes