[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Use common PCR module

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18674 )

Change subject: soc/intel/skylake: Use common PCR module
......................................................................


Patch Set 12:

(1 comment)

https://review.coreboot.org/#/c/18674/12/src/soc/intel/skylake/include/soc/pcr_ids.h
File src/soc/intel/skylake/include/soc/pcr_ids.h:

Line 107: #define PCR_REG_MASK		(~3)
> The shift is. But nothing else aside from port ids as far as I can see in t
Aaron, i meant this one R_PCH_PCR_ITSS_PIRQA_ROUT


-- 
To view, visit https://review.coreboot.org/18674
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9336883514298e7f93fbc95aef8228202aa6fb9
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes