[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Use common PCR module

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18674 )

Change subject: soc/intel/skylake: Use common PCR module
......................................................................


Patch Set 12:

(6 comments)

https://review.coreboot.org/#/c/18674/12/src/soc/intel/skylake/bootblock/pch.c
File src/soc/intel/skylake/bootblock/pch.c:

Line 241: 			B_PCH_PCR_RTC_CONF_UCMOS_EN);
> We have just pcr_or32() now.
Done


https://review.coreboot.org/#/c/18674/12/src/soc/intel/skylake/finalize.c
File src/soc/intel/skylake/finalize.c:

Line 66: 	pcr_and_then_or_32(PID_PSF1, PSF_BASE_ADDRESS + PCH_PCR_PSFX_T0_SHDW_PCIEN,
> > 80
Done


Line 176: 			       B_PCH_PCR_DMI_GCS_BILD);
> pcr_or8
Done


https://review.coreboot.org/#/c/18674/12/src/soc/intel/skylake/gpio.c
File src/soc/intel/skylake/gpio.c:

Line 132: 	regs = pcr_reg_address(comm->port_id, 0);
> imo, I think having a gpio_community_regs() inline function would be cleare
Done


https://review.coreboot.org/#/c/18674/12/src/soc/intel/skylake/include/soc/pcr_ids.h
File src/soc/intel/skylake/include/soc/pcr_ids.h:

Line 107: #define PCR_REG_MASK		(~3)
> I think I had quite a few questions on the apollolake patch that apply on w
do u recommend to split this header between pcr_ids.h and pcr_regs_def.h to split Port ID and Register def?


https://review.coreboot.org/#/c/18674/12/src/soc/intel/skylake/smihandler.c
File src/soc/intel/skylake/smihandler.c:

Line 433: 	trap_sts = pcr_read32(PID_PSTH, R_PCH_PCR_PSTH_TRPST);
> Interesting that we're reading with 32 bits and truncating to 8 on the writ
Done


-- 
To view, visit https://review.coreboot.org/18674
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9336883514298e7f93fbc95aef8228202aa6fb9
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes