[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: Add new port

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19128 )

Change subject: mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 1:

If you rebase on https://review.coreboot.org/#/c/19139/ you could possible link different gpio_'variant'.c files in Makefile.inc

Also you don't need to create a new dir for this. 
In x201 Kconfig you can have 
'if BOARD_LENOVO_X201 || BOARD_LENOVO_T410' etc. look at apple/macbook21 Kconfig and Kconfig.name as an example.

-- 
To view, visit https://review.coreboot.org/19128
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17fb1d6a954fa1b231471f322b0db13ec50711e1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No