[coreboot-gerrit] Change in coreboot[master]: libpayload: Add gru config

Paul Kocialkowski (Code Review) gerrit at coreboot.org
Wed Apr 5 09:55:37 CEST 2017


Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/19137 )

Change subject: libpayload: Add gru config
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19137/1/payloads/libpayload/configs/config.gru
File payloads/libpayload/configs/config.gru:

Line 1: CONFIG_LP_CHROMEOS=y
> Why does Chrome OS support(?) need to be selected?
This a Chrome OS device, for which several (CrOS-specific) information is passed from coreboot to the payload (depthcharge) through libpayload. Selecting this config allows that setup.

Note that other payloads (e.g. GRUB2) may use these information structures as well in the future, so it's good to have them enabled by default.


-- 
To view, visit https://review.coreboot.org/19137
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e79b763fc497c126612b8786a669a33b57ea29f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Kocialkowski <contact at paulk.fr>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Kocialkowski <contact at paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list