[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel ITSS driver support

[Barnali Sarkar (Code Review)]

Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/19125 )

Change subject: soc/intel/common/block: Add Intel ITSS driver support
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/19125/1//COMMIT_MSG
Commit Message:

PS1, Line 7: driver
Please don't use the word "driver" anywhere in commit msg.
Check other patches for reference.


https://review.coreboot.org/#/c/19125/1/src/soc/intel/common/block/ITSS/Kconfig
File src/soc/intel/common/block/ITSS/Kconfig:

PS1, Line 1: SOC_INTEL_ITSS_DRIVER
Don't use the word *DRIVER* in the Kconfig name.
Change it to "SOC_INTEL_COMMON_BLOCK_ITSS".
See other current ongoing patches for reference.

Initially we thought of this name, but Aaron don't want the word Driver anywhere.


PS1, Line 4: Driver
Remove "Driver" word


https://review.coreboot.org/#/c/19125/1/src/soc/intel/common/block/ITSS/Makefile.inc
File src/soc/intel/common/block/ITSS/Makefile.inc:

PS1, Line 1: CONFIG_SOC_INTEL_ITSS_DRIVER
Same


https://review.coreboot.org/#/c/19125/1/src/soc/intel/common/block/ITSS/itss.c
File src/soc/intel/common/block/ITSS/itss.c:

PS1, Line 17: #include <soc/pcr.h>
I think you have to use common/blocks/include/intelblocks/pcr.h file here.

There will be no soc/pcr.h file once we have the PCR patches merged.


PS1, Line 29: dev_find_slot
dev_find_slot() is defined in device/device.h which is not included here in this file.

Have you compiled the code (selecting the Kconfig of this IP from SKL SOC)?


-- 
To view, visit https://review.coreboot.org/19125
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I133294188eb5d1312caeafcb621fb650a7fab371
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-HasComments: Yes