[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add support for common GSPI controller

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19098 )

Change subject: soc/intel/common: Add support for common GSPI controller
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/19098/5/src/soc/intel/common/block/gspi/gspi.c
File src/soc/intel/common/block/gspi/gspi.c:

Line 389: 	const struct spi_slave *dev;
> If you added the base address to this function you could obtain the mmio re
Done.


https://review.coreboot.org/#/c/19098/5/src/soc/intel/common/block/include/intelblocks/gspi.h
File src/soc/intel/common/block/include/intelblocks/gspi.h:

Line 36: uintptr_t soc_get_gspi_bus_base_address(unsigned int spi_bus);
> Let's be consistent and put gspi_ first in the function names. soc can come
Done


-- 
To view, visit https://review.coreboot.org/19098
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb91eba2c523be457fee8922c44fb500a9fa140
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes