[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Set sdcard card detect (CD) host owner...

[Venkateswarlu V Vinjamuri (Code Review)]

Venkateswarlu V Vinjamuri has posted comments on this change. ( https://review.coreboot.org/18947 )

Change subject: soc/intel/apollolake: Set sdcard card detect (CD) host ownership
......................................................................


Patch Set 6:

(6 comments)

https://review.coreboot.org/#/c/18947/6//COMMIT_MSG
Commit Message:

Line 16: BUG=chrome-os-partner:35648535
> BUG=b:35648535
Done


https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/acpi.c
File src/soc/intel/apollolake/acpi.c:

Line 157: 	uint16_t pad_off = 0;
> Why is this declared and initialized here? The initialization is superfluou
Done


https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/acpi/globalnvs.asl
File src/soc/intel/apollolake/acpi/globalnvs.asl:

Line 44: 	HSAD,	8,      // 0x2F - HOSTSW_REG address
> Which is specific to the SD cd pin so it should be prefixd with SC like the
Done


https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/acpi/gpiolib.asl
File src/soc/intel/apollolake/acpi/gpiolib.asl:

Line 68: 	/* Get Host ownership of GPIO pad  */
> Isn't this reading the entire host ownership reg? It's not just a single pa
Done


https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/gpio.c
File src/soc/intel/apollolake/gpio.c:

PS6, Line 215: hostsw_reg_addr;
> will change it
Done


https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/include/soc/gpio.h
File src/soc/intel/apollolake/include/soc/gpio.h:

PS6, Line 169: addres
> It's a register offset relative to the community registers. It's not an add
Done


-- 
To view, visit https://review.coreboot.org/18947
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042a8762dc1f9cb73e6a24c1e7169c9746b2ee14
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar at intel.com>
Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes