[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: try to wake cr50 if it is asleep
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Tue Apr 4 21:46:26 CEST 2017
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19112 )
Change subject: drivers/spi/tpm: try to wake cr50 if it is asleep
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/19112/2/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:
PS2, Line 118: /*
: * Give it 10 ms. TODO(vbendeb): remove this once cr50 SPS TPM driver
: * performance is fixed.
: */
: mdelay(10);
> You try removing this yet?
Yes, thats removed in follow-up CL: https://review.coreboot.org/#/c/19113
--
To view, visit https://review.coreboot.org/19112
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6324f3c02da55a8527f085ba463cbb1f4fb5dc2e
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list