[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Check for NULL return from pci_lookup_name
Youness Alaoui (Code Review)
gerrit at coreboot.org
Tue Apr 4 19:33:55 CEST 2017
Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19089 )
Change subject: util/intelmetool: Check for NULL return from pci_lookup_name
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19089/1//COMMIT_MSG
Commit Message:
PS1, Line 10: would
> It 'would' result in undefined behavior, and as such 'could' crash.
lol, ok. I checked, and it's officially 'undefined behavior' indeed. I just saw it as trying to access address 0x0000000 which is a segfault.
--
To view, visit https://review.coreboot.org/19089
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I499f0b5e1681f3926df0d8a325aab2c666ebd632
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list