[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/raminit: Add debugging output

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/17608 )

Change subject: nb/intel/sandybridge/raminit: Add debugging output
......................................................................


nb/intel/sandybridge/raminit: Add debugging output

Add debugging output to normalize_training.

Tested on Lenovo T420.

Change-Id: I1d787f7ead6cf35ee142a8848837840c91cb6967
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-on: https://review.coreboot.org/17608
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Tested-by: build bot (Jenkins)
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Arthur Heymans: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index 9d8e349..8baa0f2 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -3029,9 +3029,15 @@
 		int delta;
 		FOR_ALL_LANES mat =
 		    max(ctrl->timings[channel][slotrank].lanes[lane].timA, mat);
-		 delta = (mat >> 6) - ctrl->timings[channel][slotrank].val_4028;
-		 ctrl->timings[channel][slotrank].val_4024 += delta;
-		 ctrl->timings[channel][slotrank].val_4028 += delta;
+		printram("normalize %d, %d, %d: mat %d\n",
+		    channel, slotrank, lane, mat);
+
+		delta = (mat >> 6) - ctrl->timings[channel][slotrank].val_4028;
+		printram("normalize %d, %d, %d: delta %d\n",
+		    channel, slotrank, lane, delta);
+
+		ctrl->timings[channel][slotrank].val_4024 += delta;
+		ctrl->timings[channel][slotrank].val_4028 += delta;
 	}
 
 	FOR_ALL_POPULATED_CHANNELS {

-- 
To view, visit https://review.coreboot.org/17608
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d787f7ead6cf35ee142a8848837840c91cb6967
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)