[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Add a Kconfig option to add backlight_pwm fil...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19091 )

Change subject: nb/intel/gm45: Add a Kconfig option to add backlight_pwm file to CBFS
......................................................................


Patch Set 3:

> What about an NVRAM option?

https://review.coreboot.org/#/c/18191/ IMO it is a bad idea to have something that can accidentally be ill configured.

-- 
To view, visit https://review.coreboot.org/19091
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2453304328dfbf2cbc114cf9e4192627b22400
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No