[coreboot-gerrit] Change in coreboot[master]: Makefile.inc: Use perl to generate ps2-keyboard-spinup file
Arthur Heymans (Code Review)
gerrit at coreboot.org
Tue Apr 4 13:55:53 CEST 2017
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19108
to look at the new patch set (#2).
Change subject: Makefile.inc: Use perl to generate ps2-keyboard-spinup file
......................................................................
Makefile.inc: Use perl to generate ps2-keyboard-spinup file
This file, used to define a timeout for seabios for the PS2 keyboard
to come up, is generated using 'cbfstool add-int'. The problem with
this is that it conflicts when an image gets updated. A workaround was
to not update that file when updating an image.
When a file is created and included in CBFS this problem does arise.
This file needs to be an 8bit little endian represented integer.
Perl is installed on most systems so it would be the right tool to
create this.
Change-Id: I46b393c805cc62259ce0f99a8946e98f5378dc41
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M Makefile.inc
1 file changed, 13 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/19108/2
--
To view, visit https://review.coreboot.org/19108
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b393c805cc62259ce0f99a8946e98f5378dc41
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list