[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Cleanup code by using common FAST_SPI ...

[Barnali Sarkar (Code Review)]

Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/19080 )

Change subject: soc/intel/apollolake: Cleanup code by using common FAST_SPI module
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/19080/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Cleanup
> The verb is spelled with a space *Clean up*.
ok, will fix


PS1, Line 9: This patch currently contains the following -
           :     1. Use SOC_INTEL_COMMON_BLOCK_FAST_SPI kconfig for common FAST_SPI code.
           :     2. Perform FAST_SPI programming by calling APIs from common FAST_SPI library.
           :     3. Use common FAST_SPI header file.
> Please don’t indent the code.
ok, will fix


https://review.coreboot.org/#/c/19080/1/src/soc/intel/apollolake/flash_ctrlr.c
File src/soc/intel/apollolake/flash_ctrlr.c:

Line 97: 	return fast_spi_flash_ctrlr_reg_read(SPIBAR_PTDATA);
> These accesses are significantly different now since you're doing a pci con
I will revert this change, and keep the ctx structure process.


https://review.coreboot.org/#/c/19080/1/src/soc/intel/apollolake/mmap_boot.c
File src/soc/intel/apollolake/mmap_boot.c:

Line 77: 	 * Returns bios_start and fills in size of the BIOS region.
> I don't think this comment is adding any value.
ok, will remove it.


-- 
To view, visit https://review.coreboot.org/19080
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd72734dadda541fe4c828e4f1716e532ec69c27
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes