[coreboot-gerrit] Change in coreboot[master]: AGESA f14: Fix MemContext buffer parser for AmdInitPost()

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19041 )

Change subject: AGESA f14: Fix MemContext buffer parser for AmdInitPost()
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/19041/3//COMMIT_MSG
Commit Message:

Line 14: 
Instead of saying that there's a mis-interpretation, it would be useful to say what it the issue is:

Here's how I'm seeing the problem:

When RegisterSize is 3 in the register playback tables, no register is saved or restored. Instead a function is called to do certain things in the save and resume sequence.  Previously, this was overlooked, and the pointer containing the current OrMask was still incremented by 3 bytes.


-- 
To view, visit https://review.coreboot.org/19041
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7221a03d5a4e442817911ba4862e3c0e8fa4a500
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes