[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: Add new port
Ani Chang (Code Review)
gerrit at coreboot.org
Tue Apr 4 02:12:50 CEST 2017
Ani Chang has posted comments on this change. ( https://review.coreboot.org/19079 )
Change subject: mainboard/lenovo/t410: Add new port
......................................................................
Patch Set 4:
> (1 comment)
>
> It looks a bit different from x201 gpios so either create a
> variants dir with separate gpio.h or use #if CONFIG_BOARD_LENOVO_X201
> for differences.
>
> This should do it:
>
> const struct pch_gpio_set1 pch_gpio_set1_mode = {
> .gpio0 = GPIO_MODE_GPIO,
...
Pasted in gpio.h and committed.
Now I should turn this dir into a variant. Is there an example already in the repo?
--
To view, visit https://review.coreboot.org/19079
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80ea9ea4787c6cacf0640ce828bf083d616c91f9
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
More information about the coreboot-gerrit
mailing list