[coreboot-gerrit] Change in coreboot[master]: AGESA: Refactor S3 support functions

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19037 )

Change subject: AGESA: Refactor S3 support functions
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/19037/2/src/northbridge/amd/agesa/oem_s3.c
File src/northbridge/amd/agesa/oem_s3.c:

PS2, Line 89: HIGH_MEMORY_SCRATCH
Does it still make sense to use BIOS_HEAP_SIZE, since that's the maximum that will be used?  It's equal or less than HIGH_MEMORY_SCRATCH.

I'm good with either way, just thought I'd raise the question.


-- 
To view, visit https://review.coreboot.org/19037
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbf6581a0bf1d4bffda870fc055721627b538b92
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes