[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/tpm: use iobuf library for marshaling commands

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19063 )

Change subject: drivers/i2c/tpm: use iobuf library for marshaling commands
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19063/2/src/lib/tpm2_marshaling.c
File src/lib/tpm2_marshaling.c:

PS2, Line 292: rc |= obuf_write_be16(ob, 0);
             : 	rc |= obuf_write_be32(ob, 0);
             : 	rc |= obuf_write_be32(ob, command);
> Sure, but by doing this we've ensured the buffer is initialized to somethin
Ohh.. so the plan is to move the session information before the marshal path as well? Then, it would make sense to just let the size be filled in later.


-- 
To view, visit https://review.coreboot.org/19063
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec0bbff1312e8e6ec616d1528db8667f32e682c9
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-HasComments: Yes