[coreboot-gerrit] Change in coreboot[master]: commonlib: add input and output buffer helpers

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19062 )

Change subject: commonlib: add input and output buffer helpers
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

Just minor nits.. LGTM, otherwise.

https://review.coreboot.org/#/c/19062/2/src/commonlib/include/commonlib/iobuf.h
File src/commonlib/include/commonlib/iobuf.h:

PS2, Line 80: obuf
ibuf


Line 128: 
Do we need something like obuf_fast_forward or obuf_skip which basically just increments nr_written?


Line 144: 
extra blank


-- 
To view, visit https://review.coreboot.org/19062
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5247237f68b658906ec6916bbbb286d57d6df5ee
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes