[coreboot-gerrit] Change in coreboot[master]: AMD geode: Avoid conflicting mainboard_romstage_entry() decl...

Marshall Dawson (Code Review) gerrit at coreboot.org
Mon Apr 3 17:53:27 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18769

to look at the new patch set (#2).

Change subject: AMD geode: Avoid conflicting mainboard_romstage_entry() declaration
......................................................................

AMD geode: Avoid conflicting mainboard_romstage_entry() declaration

Different romstages may have different mainboard_romstage_entry()
requirements. Only include it based on the geode silicon.

Note:
The definition would normally be in a silicon specific
romstage.h and not in include/cpu/amd/car.h, but geode doesn't
have a common romstage.

Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/include/cpu/amd/car.h
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/18769/2
-- 
To view, visit https://review.coreboot.org/18769
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list