[coreboot-gerrit] Change in coreboot[master]: mainboard/winnet/g170: Copy from mainboard/bcom/winnetp680

[Lubomir Rintel (Code Review)]

Lubomir Rintel has posted comments on this change. ( https://review.coreboot.org/18898 )

Change subject: mainboard/winnet/g170: Copy from mainboard/bcom/winnetp680
......................................................................


Patch Set 4:

(2 comments)

In current version of the patch set I've changed neoware/g170 to winnet/g170. Turns out the board is one of boards manufactured by "WinNET" that is used by different thin client vendors.

The existing "BCom" WinNET p680 should probably be moved under winnet/. I'm not doing this now, because I'm not sure how to do that. Is it all right to move a board? Should the config option names stay intact?

https://review.coreboot.org/#/c/18898/1/src/mainboard/neoware/g170/romstage.c
File src/mainboard/neoware/g170/romstage.c:

Line 30
> We are slowly removing all .c includes.
> We are slowly removing all .c includes.

Done. See Ia369ece6365accbc531736fc463c713bbc134807 and Ie1bc538aa29c4f18dd6f31a83d3da58f196f2078


Line 30
> See this commit:
> See this commit:
 > https://review.coreboot.org/#/c/18484/

Thank you; this was helpful.


-- 
To view, visit https://review.coreboot.org/18898
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90b89ee634d90cfba2e56cca5b76cfd2bd7a8d0b
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes