[coreboot-gerrit] Change in coreboot[master]: northbridge/via/cn700: Add some delays during raminit

Lubomir Rintel (Code Review) gerrit at coreboot.org
Mon Apr 3 17:18:31 CEST 2017


Lubomir Rintel has posted comments on this change. ( https://review.coreboot.org/18893 )

Change subject: northbridge/via/cn700: Add some delays during raminit
......................................................................


Patch Set 4:

(1 comment)

> (2 comments)

I'd prefer to just use a helper routine without the configuration option, as Kyösti suggested; that is -- unless you feel strongly about this.

I am not able to check whether this is specific to some silicon revision. The data sheet doesn't seem to have anything relevant to say.

https://review.coreboot.org/#/c/18893/1//COMMIT_MSG
Commit Message:

PS1, Line 13: register
> registers.
Done


-- 
To view, visit https://review.coreboot.org/18893
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aa38768d84dd42c9c720c917a99e6b4b1e03427
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list