[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Code clean up by using common PCR module

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18673 )

Change subject: soc/intel/apollolake: Code clean up by using common PCR module
......................................................................


Patch Set 7:

(3 comments)

https://review.coreboot.org/#/c/18673/7/src/soc/intel/apollolake/bootblock/bootblock.c
File src/soc/intel/apollolake/bootblock/bootblock.c:

PS7, Line 50: pcr_read32(PID_RTC, R_PCH_PCR_RTC_CONF, &reg);
            : 	reg |= B_PCH_PCR_RTC_CONF_UCMOS_EN;
            : 	pcr_write32(PID_RTC, R_PCH_PCR_RTC_CONF, reg);
> why not use pcr_and_then_or?
Done


https://review.coreboot.org/#/c/18673/7/src/soc/intel/apollolake/gpio.c
File src/soc/intel/apollolake/gpio.c:

PS7, Line 123: pcr_read32(port, hostsw_reg, &val);
             : 	val |= 1 << (pin % 32);
             : 	pcr_write32(port, hostsw_reg, val);
> pcr_and_then_or?
Done


PS7, Line 147: pcr_read32(port, en_reg, &value);
             : 	value |= 1 << (pin % GPIO_MAX_NUM_PER_GROUP);
             : 	pcr_write32(port, en_reg , value);
> pcr_and_then_or
Done


-- 
To view, visit https://review.coreboot.org/18673
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbf58dbd55bf3915676d875fcb484362d357a44
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes