[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: Add new port

[Ani Chang (Code Review)]

Ani Chang has posted comments on this change. ( https://review.coreboot.org/19079 )

Change subject: mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 2:

> You could also revive d9d872e643dd242e925bfb46d18076e6ad100995 [1],
 > which was abandoned, as Nicolas didn’t follow up on it.
 > 
 > [1] https://review.coreboot.org/11791/

There is not much to revive. It is exactly the same laptop of x201 ... the memory map is the same.
I'd 

 > You could also revive d9d872e643dd242e925bfb46d18076e6ad100995 [1],
 > which was abandoned, as Nicolas didn’t follow up on it.
 > 
 > [1] https://review.coreboot.org/11791/

There's not much to revive. T410 and X201 are the same board with different layouts. On T410 there is the SD card slot on USB; that is the only difference.
I'd like to follow Kyösti Mälkki advice, but I don't know how to make a variant.
I'd do an alias instead of a variant...

-- 
To view, visit https://review.coreboot.org/19079
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80ea9ea4787c6cacf0640ce828bf083d616c91f9
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No