[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 )

Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
......................................................................


Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/19043/5/src/mainboard/siemens/mc_apl1/ptn3460.c
File src/mainboard/siemens/mc_apl1/ptn3460.c:

PS5, Line 54: 1
> Shouldn't these 1's be PTN error codes? That's what you have according to y
No, these are not PTN error codes. At this point we have problems to get the data required for the PTN.
In a future driver solution this part will disappear. I changed the comment for the moment.


https://review.coreboot.org/#/c/19043/5/src/mainboard/siemens/mc_apl1/ptn3460.h
File src/mainboard/siemens/mc_apl1/ptn3460.h:

Line 19: #include <stdint.h>
> You should include stdint.h so this header is not implicitly dependent on s
Done


-- 
To view, visit https://review.coreboot.org/19043
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes