[coreboot-gerrit] Change in coreboot[master]: Documentation: Describe libgfxinit hook-up
Martin Roth (Code Review)
gerrit at coreboot.org
Mon Apr 3 07:12:22 CEST 2017
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19054 )
Change subject: Documentation: Describe libgfxinit hook-up
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/19054/2/Documentation/gfx/libgfxinit.md
File Documentation/gfx/libgfxinit.md:
PS2, Line 10: control-
: lers
> Yes, you're right. I'm trying to fix this, but it seems to be a lost
Why not just move the whole word to the next line? We'd like it to be markdown, not text.
Why are you wrapping at 70 anyway?
PS2, Line 57:
> Which states "..., simply indent _every_ line of the block by at least 4
Hrm. I looked at it in a markdown viewer. That's why I made the comments. But it seems that Atom's markdown preview interprets it incorrectly.
Two other markdown viewers (including hugo) show it the way you intended, so you're good - I withdraw my comment. :)
--
To view, visit https://review.coreboot.org/19054
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb53a1694193cd19b5e9aa5bee25e36a60e56bd
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list