[coreboot-gerrit] Change in coreboot[master]: AGESA: Refactor S3 support functions

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19037 )

Change subject: AGESA: Refactor S3 support functions
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19037/1/src/northbridge/amd/agesa/oem_s3.c
File src/northbridge/amd/agesa/oem_s3.c:

PS1, Line 67: if (len == 0 || len == (u32)-1ULL)
            : 		return AGESA_FATAL;
I don't understand this check.  This value is determined from a Kconfig option added to a constant, so I don't see how it's likely to be 0 or -1.

For Agesa, this is:
0xFFFF0000 + 0x1000
For the PI family this will also be:
0xFFFF0000 + 0x1000
For Family 10h, it's:
0x0 + 0x1000

There's no Kconfig prompt, so those values will always be fixed.


-- 
To view, visit https://review.coreboot.org/19037
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbf6581a0bf1d4bffda870fc055721627b538b92
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes