[coreboot-gerrit] Change in coreboot[master]: Documentation: Describe libgfxinit hook-up

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19054 )

Change subject: Documentation: Describe libgfxinit hook-up
......................................................................


Patch Set 2:

(3 comments)

Maybe say something about building the Ada compiler?  Should we enable it by default in the makefile target for crossgcc-i386?

https://review.coreboot.org/#/c/19054/2/Documentation/gfx/libgfxinit.md
File Documentation/gfx/libgfxinit.md:

PS2, Line 13: Core i
This looks awkward - maybe "Intel Core i3/i5/i7 processor line"


PS2, Line 57:                 
This indentation causes a code block with just the rest of this line in it.

https://daringfireball.net/projects/markdown/syntax#precode


PS2, Line 59:                 failed `0`. Currently, only the case that no display
            :                 could be found counts as failure. A failure at a la-
            :                 ter stage (e.g. failure to train a DP) is not propa-
            :                 gated.
same - indentation causes a code block containing the rest of this text.


-- 
To view, visit https://review.coreboot.org/19054
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb53a1694193cd19b5e9aa5bee25e36a60e56bd
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes