[coreboot-gerrit] Change in coreboot[master]: cpu/intel/model_106cx: Add tsc_freq_mhz() function

Sumeet R Pawnikar (Code Review) gerrit at coreboot.org
Sat Apr 1 14:25:11 CEST 2017


Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/19067 )

Change subject: cpu/intel/model_106cx: Add tsc_freq_mhz() function
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/tsc_freq.c
File src/cpu/intel/model_106cx/tsc_freq.c:

PS1, Line 4: 2014
Need to correct this to 2017


PS1, Line 29: 400
>From where this value came ? can we use macro for this ?


PS1, Line 32: 533
same as above comment.


-- 
To view, visit https://review.coreboot.org/19067
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb6074f3f097d7e6fc501a376754a05eb9e4faa0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list