[coreboot-gerrit] Change in coreboot[master]: cpu/intel/model_106cx: Add tsc_freq_mhz() function

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19067 )

Change subject: cpu/intel/model_106cx: Add tsc_freq_mhz() function
......................................................................


Patch Set 1:

(2 comments)

Maybe it is better to use MCHBAR(CLKCFG) since that one actually reflects BSEL straps. Not sure if physically possible on these CPUs but for instance on LGA775 BSEL straps can modified in some cases...

https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/Makefile.inc
File src/cpu/intel/model_106cx/Makefile.inc:

PS1, Line 5: romstage-y += tsc_freq.c
           : smm-y      += tsc_freq.c
> Does it have any effect on these stages?
Not sure. I just copied it from other Intel Makefile.inc.


https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/tsc_freq.c
File src/cpu/intel/model_106cx/tsc_freq.c:

> This looks the same as `model_1067x/fsc_freq.c`. But right now, no
you mean model_2065x ?


-- 
To view, visit https://review.coreboot.org/19067
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb6074f3f097d7e6fc501a376754a05eb9e4faa0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes