[coreboot-gerrit] New patch to review for coreboot: google/gale: Remove #ifdef of Kconfig bool symbol

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16837

-gerrit

commit f4d0e8e7b6292292bcb82ef8080b71bdffc0e5d2
Author: Martin Roth <martinroth at google.com>
Date:   Fri Sep 30 14:51:24 2016 -0600

    google/gale: Remove #ifdef of Kconfig bool symbol
    
    Kconfig symbols of type bool are ALWAYS defined, so this code was
    always being included and run, which isn't what the author wanted.
    
    Change to use IS_ENABLED(), and a regular if() instead of an #ifdef.
    
    Change-Id: I72623fa27e47980c602135f4b73f371c7f50139b
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/google/gale/verstage.c | 55 ++++++++++++++++++------------------
 1 file changed, 27 insertions(+), 28 deletions(-)

diff --git a/src/mainboard/google/gale/verstage.c b/src/mainboard/google/gale/verstage.c
index cdc4386..1a3f5a4 100644
--- a/src/mainboard/google/gale/verstage.c
+++ b/src/mainboard/google/gale/verstage.c
@@ -24,34 +24,33 @@
 static void ipq_setup_tpm(void)
 {
 
-#ifdef CONFIG_I2C_TPM
-	gpio_tlmm_config_set(TPM_RESET_GPIO, FUNC_SEL_GPIO,
-			     GPIO_PULL_UP, GPIO_6MA, 1);
-	gpio_set(TPM_RESET_GPIO, 0);
-	udelay(100);
-	gpio_set(TPM_RESET_GPIO, 1);
-
-	/*
-	 * ----- Per the SLB 9615XQ1.2 spec -----
-	 *
-	 * 4.7.1 Reset Timing
-	 *
-	 * The TPM_ACCESS_x.tpmEstablishment bit has the correct value
-	 * and the TPM_ACCESS_x.tpmRegValidSts bit is typically set
-	 * within 8ms after RESET# is deasserted.
-	 *
-	 * The TPM is ready to receive a command after less than 30 ms.
-	 *
-	 * --------------------------------------
-	 *
-	 * I'm assuming this means "wait for 30ms"
-	 *
-	 * If we don't wait here, subsequent QUP I2C accesses
-	 * to the TPM either fail or timeout.
-	 */
-	mdelay(30);
-
-#endif /* CONFIG_I2C_TPM */
+	if (IS_ENABLED(CONFIG_I2C_TPM)) {
+		gpio_tlmm_config_set(TPM_RESET_GPIO, FUNC_SEL_GPIO,
+				     GPIO_PULL_UP, GPIO_6MA, 1);
+		gpio_set(TPM_RESET_GPIO, 0);
+		udelay(100);
+		gpio_set(TPM_RESET_GPIO, 1);
+
+		/*
+		 * ----- Per the SLB 9615XQ1.2 spec -----
+		 *
+		 * 4.7.1 Reset Timing
+		 *
+		 * The TPM_ACCESS_x.tpmEstablishment bit has the correct value
+		 * and the TPM_ACCESS_x.tpmRegValidSts bit is typically set
+		 * within 8ms after RESET# is deasserted.
+		 *
+		 * The TPM is ready to receive a command after less than 30 ms.
+		 *
+		 * --------------------------------------
+		 *
+		 * I'm assuming this means "wait for 30ms"
+		 *
+		 * If we don't wait here, subsequent QUP I2C accesses
+		 * to the TPM either fail or timeout.
+		 */
+		mdelay(30);
+	}
 }
 
 void verstage_mainboard_init(void)