[coreboot-gerrit] New patch to review for coreboot: Kconfig: Prefix hex defaults with 0x

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Sep 29 23:29:09 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16827

-gerrit

commit 383a995e861651c26663740dba84dacf4f609ce2
Author: Martin Roth <martinroth at google.com>
Date:   Thu Sep 29 14:46:24 2016 -0600

    Kconfig: Prefix hex defaults with 0x
    
    Because these variables had "non-hexidecimal" defaults, they
    were updated by kconfig when writing defconfig files.
    
    Change-Id: Ic1a070d340708f989157ad18ddc79de7bb92d873
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/drivers/intel/fsp1_1/Kconfig   | 4 ++--
 src/drivers/uart/Kconfig           | 2 +-
 src/mainboard/google/daisy/Kconfig | 2 +-
 src/mainboard/google/smaug/Kconfig | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/drivers/intel/fsp1_1/Kconfig b/src/drivers/intel/fsp1_1/Kconfig
index 17a5caf..306e09b 100644
--- a/src/drivers/intel/fsp1_1/Kconfig
+++ b/src/drivers/intel/fsp1_1/Kconfig
@@ -34,13 +34,13 @@ config HAVE_FSP_BIN
 
 config CPU_MICROCODE_CBFS_LEN
 	hex "Microcode update region length in bytes"
-	default 0
+	default 0x0
 	help
 	  The length in bytes of the microcode update region.
 
 config CPU_MICROCODE_CBFS_LOC
 	hex "Microcode update base address in CBFS"
-	default 0
+	default 0x0
 	help
 	  The location (base address) in CBFS that contains the microcode update
 	  binary.
diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig
index 4faa48d..698564e 100644
--- a/src/drivers/uart/Kconfig
+++ b/src/drivers/uart/Kconfig
@@ -65,7 +65,7 @@ config UART_USE_REFCLK_AS_INPUT_CLOCK
 
 config UART_PCI_ADDR
 	hex "UART's PCI bus, device, function address"
-	default 0
+	default 0x0
 	help
 	  Specify zero if the UART is connected to another bus type.
 	  For PCI based UARTs, build the value as:
diff --git a/src/mainboard/google/daisy/Kconfig b/src/mainboard/google/daisy/Kconfig
index cef3f61..29d6690 100644
--- a/src/mainboard/google/daisy/Kconfig
+++ b/src/mainboard/google/daisy/Kconfig
@@ -49,7 +49,7 @@ config DRAM_SIZE_MB
 
 config EC_GOOGLE_CHROMEEC_I2C_BUS
 	hex
-	default 4
+	default 0x4
 
 config UART_FOR_CONSOLE
 	int
diff --git a/src/mainboard/google/smaug/Kconfig b/src/mainboard/google/smaug/Kconfig
index 15ff2b3..6655453 100644
--- a/src/mainboard/google/smaug/Kconfig
+++ b/src/mainboard/google/smaug/Kconfig
@@ -85,7 +85,7 @@ config DRIVER_TPM_I2C_ADDR
 
 config EC_GOOGLE_CHROMEEC_I2C_BUS
 	hex
-	default 1
+	default 0x1
 
 config EC_GOOGLE_CHROMEEC_BOARDNAME
 	string



More information about the coreboot-gerrit mailing list