[coreboot-gerrit] New patch to review for coreboot: mvmap2315: Skip uart_init when serial is disabled

Daisuke Nojiri (dnojiri@chromium.org) gerrit at coreboot.org
Mon Sep 26 21:49:13 CEST 2016


Daisuke Nojiri (dnojiri at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16746

-gerrit

commit 2174be47093eb472494fa5007b84f4f65241b134
Author: Daisuke Nojiri <dnojiri at chromium.org>
Date:   Mon Sep 26 10:46:53 2016 -0700

    mvmap2315: Skip uart_init when serial is disabled
    
    When coreboot is built with CONFIG_CONSOLE_SERIAL not set, uart_init
    does not exist, causing compilation to fail. This patch fixes it by
    skipping uart_init when serial is disabled.
    
    BUG=none
    BRANCH=none
    TEST=emerge-rotor coreboot
    
    Change-Id: If7f475eae9008b392f8f1e5cb5568c93113ee3f1
    Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>
---
 src/soc/marvell/mvmap2315/bootblock.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/soc/marvell/mvmap2315/bootblock.c b/src/soc/marvell/mvmap2315/bootblock.c
index 6b0a333..4a9ea08 100644
--- a/src/soc/marvell/mvmap2315/bootblock.c
+++ b/src/soc/marvell/mvmap2315/bootblock.c
@@ -94,8 +94,10 @@ void bootblock_soc_init(void)
 	ap_start((void *)MVMAP2315_ROMSTAGE_BASE);
 
 	/* initializing UART1 to free UART0 to be used by romstage */
+#if __CONSOLE_SERIAL_ENABLE__
 	uart_num = 1;
 	uart_init(uart_num);
+#endif
 
 	while (read32((void *)MVMAP2315_BOOTBLOCK_CB1) != 0x4)
 		;



More information about the coreboot-gerrit mailing list