[coreboot-gerrit] Patch set updated for coreboot: intel/gma/vbt.c: pad the ID string with spaces.

Arthur Heymans (arthur@aheymans.xyz) gerrit at coreboot.org
Mon Sep 26 13:23:56 CEST 2016


Arthur Heymans (arthur at aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16739

-gerrit

commit ca5999f8728bb690aa3533b25c68ff05f35445af
Author: Arthur Heymans <arthur at aheymans.xyz>
Date:   Sun Sep 25 22:36:26 2016 +0200

    intel/gma/vbt.c: pad the ID string with spaces.
    
    The VBT id string is 20 characters long.
    If the string is shorter than 20 it needs spaces at the end.
    
    Change-Id: Id6439f1d3dbd09319ee99ce9d15dbc3bcead1f53
    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
 src/drivers/intel/gma/vbt.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c
index e768402..f5cc839 100644
--- a/src/drivers/intel/gma/vbt.c
+++ b/src/drivers/intel/gma/vbt.c
@@ -34,7 +34,13 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf,
 
 	memset (head, 0, sizeof (*head));
 
-	memcpy (head->signature, idstr, 20);
+	/*
+	 * make sure the 20 char length signature is filled
+	 * with spaces if the idstr is shorter than 20
+	 */
+	memset(head->signature, ' ', sizeof(head->signature));
+	memcpy(head->signature, idstr, MIN(strlen(idstr),
+						sizeof(head->signature)));
 	head->version = 100;
 	head->header_size = sizeof (*head);
 	head->bdb_offset = sizeof (*head);



More information about the coreboot-gerrit mailing list