[coreboot-gerrit] Patch merged into coreboot/master: lpss_i2c: Change handling of controller enable/disable

gerrit at coreboot.org gerrit at coreboot.org
Wed Sep 14 22:23:59 CEST 2016


the following patch was just integrated into master:
commit 772555a214e023c6e3dd267d296bef23242f3638
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Sep 12 11:20:27 2016 -0700

    lpss_i2c: Change handling of controller enable/disable
    
    This change modifies the lpss_i2c driver to behave more like
    the Linux kernel driver.  In particular the controller is only
    enabled when processing a transaction, and is disabled after.
    This means that errors in one transaction will not affect later
    transactions.
    
    Also when disabling the controller the code is supposed to wait
    on the enable bit in the "enable status" register and not in
    the enable control register.  In order to get access to this
    register the reg map was expanded to include all registers.
    
    This was tested with the cr50 TPM driver to ensure that if a
    transaction does fail that it can be successfully retried instead
    of the bus being unusable.
    
    Change-Id: I43a546d54996ba0f08550a801927b8f7a6690cda
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://review.coreboot.org/16589
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/16589 for details.

-gerrit



More information about the coreboot-gerrit mailing list