[coreboot-gerrit] Patch set updated for coreboot: northbridge/intel/e7505/debug.c: Improve code formatting

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Wed Sep 14 07:27:27 CEST 2016


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16588

-gerrit

commit 1cc04626da7d00f4272361d8c1eaa6914422eb12
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Mon Sep 12 20:19:38 2016 +0200

    northbridge/intel/e7505/debug.c: Improve code formatting
    
    Change-Id: I63f58d95fa01b1f73f3620a5d13f21ef62e2404c
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/northbridge/intel/e7505/debug.c | 85 ++++++++++++++++++-------------------
 1 file changed, 42 insertions(+), 43 deletions(-)

diff --git a/src/northbridge/intel/e7505/debug.c b/src/northbridge/intel/e7505/debug.c
index 022257c..65cd19a 100644
--- a/src/northbridge/intel/e7505/debug.c
+++ b/src/northbridge/intel/e7505/debug.c
@@ -45,7 +45,7 @@ void dump_pci_device(unsigned dev)
 	for (i = 0; i < 256; i++) {
 		unsigned char val;
 		if ((i & 0x0f) == 0)
-                        printk(BIOS_DEBUG, "\n%02x:",i);
+			printk(BIOS_DEBUG, "\n%02x:",i);
 		val = pci_read_config8(dev, i);
 		printk(BIOS_DEBUG, " %02x", val);
 	}
@@ -72,18 +72,18 @@ void dump_pci_devices(void)
 void dump_pci_devices_on_bus(unsigned busn)
 {
 	pci_devfn_t dev;
-        for (dev = PCI_DEV(busn, 0, 0);
-                dev <= PCI_DEV(busn, 0x1f, 0x7);
-                dev += PCI_DEV(0,0,1)) {
-                uint32_t id;
-                id = pci_read_config32(dev, PCI_VENDOR_ID);
-                if (((id & 0xffff) == 0x0000) || ((id & 0xffff) == 0xffff) ||
-                        (((id >> 16) & 0xffff) == 0xffff) ||
-                        (((id >> 16) & 0xffff) == 0x0000)) {
-                        continue;
-                }
-                dump_pci_device(dev);
-        }
+	for (dev = PCI_DEV(busn, 0, 0);
+		dev <= PCI_DEV(busn, 0x1f, 0x7);
+		dev += PCI_DEV(0,0,1)) {
+		uint32_t id;
+		id = pci_read_config32(dev, PCI_VENDOR_ID);
+		if (((id & 0xffff) == 0x0000) || ((id & 0xffff) == 0xffff) ||
+			(((id >> 16) & 0xffff) == 0xffff) ||
+			(((id >> 16) & 0xffff) == 0x0000)) {
+			continue;
+		}
+		dump_pci_device(dev);
+	}
 }
 
 void dump_spd_registers(const struct mem_controller *ctrl)
@@ -113,18 +113,18 @@ void dump_spd_registers(const struct mem_controller *ctrl)
 		device = ctrl->channel1[i];
 		if (device) {
 			int j;
-                        printk(BIOS_DEBUG, "dimm: %02x.1: %02x", i, device);
+			printk(BIOS_DEBUG, "dimm: %02x.1: %02x", i, device);
 			for (j = 0; j < 128; j++) {
 				int status;
 				unsigned char byte;
 				if ((j & 0xf) == 0)
-                                        printk(BIOS_DEBUG, "\n%02x: ", j);
+					printk(BIOS_DEBUG, "\n%02x: ", j);
 				status = spd_read_byte(device, j);
 				if (status < 0) {
 					break;
 				}
 				byte = status & 0xff;
-                                printk(BIOS_DEBUG, "%02x ", byte);
+				printk(BIOS_DEBUG, "%02x ", byte);
 			}
 			printk(BIOS_DEBUG, "\n");
 		}
@@ -133,53 +133,52 @@ void dump_spd_registers(const struct mem_controller *ctrl)
 void dump_smbus_registers(void)
 {
 	unsigned device;
-        printk(BIOS_DEBUG, "\n");
-        for (device = 1; device < 0x80; device++) {
-                int j;
+	printk(BIOS_DEBUG, "\n");
+	for (device = 1; device < 0x80; device++) {
+		int j;
 		if ( spd_read_byte(device, 0) < 0 ) continue;
 		printk(BIOS_DEBUG, "smbus: %02x", device);
-                for (j = 0; j < 256; j++) {
-                	int status;
-                        unsigned char byte;
-                        status = spd_read_byte(device, j);
-                        if (status < 0) {
+		for (j = 0; j < 256; j++) {
+			int status;
+			unsigned char byte;
+			status = spd_read_byte(device, j);
+			if (status < 0) {
 				break;
-                        }
-                        if ((j & 0xf) == 0)
+			}
+			if ((j & 0xf) == 0)
 				printk(BIOS_DEBUG, "\n%02x: ",j);
-                        byte = status & 0xff;
-                        printk(BIOS_DEBUG, "%02x ", byte);
-                }
-                printk(BIOS_DEBUG, "\n");
+			byte = status & 0xff;
+			printk(BIOS_DEBUG, "%02x ", byte);
+		}
+		printk(BIOS_DEBUG, "\n");
 	}
 }
 
 void dump_io_resources(unsigned port)
 {
-
 	int i;
 	printk(BIOS_DEBUG, "%04x:\n", port);
-        for (i=0;i<256;i++) {
-                uint8_t val;
-                if ((i & 0x0f) == 0)
+	for (i=0;i<256;i++) {
+		uint8_t val;
+		if ((i & 0x0f) == 0)
 			printk(BIOS_DEBUG, "%02x:", i);
-                val = inb(port);
+		val = inb(port);
 		printk(BIOS_DEBUG, " %02x",val);
-                if ((i & 0x0f) == 0x0f) {
-                        printk(BIOS_DEBUG, "\n");
-                }
+		if ((i & 0x0f) == 0x0f) {
+			printk(BIOS_DEBUG, "\n");
+		}
 		port++;
-        }
+	}
 }
 
 void dump_mem(unsigned start, unsigned end)
 {
-        unsigned i;
+	unsigned i;
 	printk(BIOS_DEBUG, "dump_mem:");
-        for (i=start;i<end;i++) {
+	for (i=start;i<end;i++) {
 		if ((i & 0xf)==0)
 			printk(BIOS_DEBUG, "\n%08x:", i);
 		printk(BIOS_DEBUG, " %02x", (unsigned char)*((unsigned char *)i));
-        }
-        printk(BIOS_DEBUG, "\n");
+	}
+	printk(BIOS_DEBUG, "\n");
 }



More information about the coreboot-gerrit mailing list