[coreboot-gerrit] New patch to review for coreboot: northbridge/intel/x4x: transition away from device_t

Antonello Dettori (dev@dettori.io) gerrit at coreboot.org
Sat Sep 3 11:42:44 CEST 2016


Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16472

-gerrit

commit 70bb5098088a18a48f70055c56a875fd2f665137
Author: Antonello Dettori <dev at dettori.io>
Date:   Sat Sep 3 10:45:33 2016 +0200

    northbridge/intel/x4x: transition away from device_t
    
    Replace the use of the old device_t definition inside
    northbridge/intel/x4x.
    
    Change-Id: I65cd02eacf57cb41ded434582ca6e9d9f655e6ea
    Signed-off-by: Antonello Dettori <dev at dettori.io>
---
 src/northbridge/intel/x4x/early_init.c | 2 +-
 src/northbridge/intel/x4x/x4x.h        | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/intel/x4x/early_init.c b/src/northbridge/intel/x4x/early_init.c
index a430538..1b0d4f9 100644
--- a/src/northbridge/intel/x4x/early_init.c
+++ b/src/northbridge/intel/x4x/early_init.c
@@ -23,7 +23,7 @@
 
 void x4x_early_init(void)
 {
-	const device_t d0f0 = PCI_DEV(0, 0, 0);
+	const pci_devfn_t d0f0 = PCI_DEV(0, 0, 0);
 
 	/* Setup MCHBAR. */
 	pci_write_config32(d0f0, D0F0_MCHBAR_LO, (uintptr_t)DEFAULT_MCHBAR | 1);
diff --git a/src/northbridge/intel/x4x/x4x.h b/src/northbridge/intel/x4x/x4x.h
index e02ee02..a97734d 100644
--- a/src/northbridge/intel/x4x/x4x.h
+++ b/src/northbridge/intel/x4x/x4x.h
@@ -324,6 +324,8 @@ void sdram_initialize(int boot_path, const u8 *spd_map);
 void raminit_ddr2(struct sysinfo *);
 
 struct acpi_rsdp;
+#ifndef __SIMPLE_DEVICE__
 unsigned long northbridge_write_acpi_tables(device_t device, unsigned long start, struct acpi_rsdp *rsdp);
+#endif /* __SIMPLE_DEVICE__ */
 #endif
 #endif /* __NORTHBRIDGE_INTEL_X4X_H__ */



More information about the coreboot-gerrit mailing list