[coreboot-gerrit] Patch set updated for coreboot: lpss_i2c: Increase default timeout to 4ms

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Fri Sep 2 01:22:22 CEST 2016


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16392

-gerrit

commit 04767c2160d373f4b715dcb61cc5060d3322f5ba
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Thu Sep 1 14:22:34 2016 -0700

    lpss_i2c: Increase default timeout to 4ms
    
    Increase the default timeout in the LPSS I2C driver to 4ms
    from 2ms.  During testing with some slower devices I found
    that the existing timeout could be too short leading to
    transaction failures.
    
    Change-Id: Ied86c7a0aa26d55b31f447c5938803c194d0045e
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/common/lpss_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/common/lpss_i2c.c b/src/soc/intel/common/lpss_i2c.c
index a9bbbb3..0c8fec4 100644
--- a/src/soc/intel/common/lpss_i2c.c
+++ b/src/soc/intel/common/lpss_i2c.c
@@ -60,8 +60,8 @@ struct lpss_i2c_regs {
 	uint32_t tx_abort_source;
 } __attribute__((packed));
 
-/* Use a ~2ms timeout for various operations */
-#define LPSS_I2C_TIMEOUT_US		2000
+/* Use a ~4ms timeout for various operations */
+#define LPSS_I2C_TIMEOUT_US		4000
 
 /* High and low times in different speed modes (in ns) */
 enum {



More information about the coreboot-gerrit mailing list