[coreboot-gerrit] Patch set updated for coreboot: [DON'T MERGE] Investigating CL #16987

[Jonathan Neuschäfer (j.neuschaefer@gmx.net)]

Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17060

-gerrit

commit d6316837105d4818354b5a6ad262ab7989b08eb0
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Wed Oct 19 02:18:54 2016 +0200

    [DON'T MERGE] Investigating CL #16987
    
    https://review.coreboot.org/#/c/16987/ results in a crash in AMDFWTOOL
    for some boards, on jenkins. With this patch, I try to figure out what's
    going on.
    
    Change-Id: Ic36b8be2b0ee458311dcc8e9139df2b4d113b4ba
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 src/mainboard/emulation/Kconfig               | 1 +
 src/southbridge/amd/agesa/hudson/Makefile.inc | 2 +-
 src/southbridge/amd/pi/hudson/Makefile.inc    | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/emulation/Kconfig b/src/mainboard/emulation/Kconfig
index 1dc89ca..759b1de 100644
--- a/src/mainboard/emulation/Kconfig
+++ b/src/mainboard/emulation/Kconfig
@@ -2,6 +2,7 @@ if VENDOR_EMULATION
 
 choice
 	prompt "Mainboard model"
+	default BOARD_EMULATION_QEMU_X86_I440FX
 
 source "src/mainboard/emulation/*/Kconfig.name"
 
diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc
index 3877e60..bb96e22 100644
--- a/src/southbridge/amd/agesa/hudson/Makefile.inc
+++ b/src/southbridge/amd/agesa/hudson/Makefile.inc
@@ -58,7 +58,7 @@ $(obj)/amdfw.rom:	$(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \
 			$(AMDFWTOOL)
 	rm -f $@
 	@printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
-	$(AMDFWTOOL) \
+	valgrind $(AMDFWTOOL) \
 		$(OPT_HUDSON_XHCI_FWM_FILE) \
 		$(OPT_HUDSON_IMC_FWM_FILE) \
 		$(OPT_HUDSON_GEC_FWM_FILE) \
diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc
index 291e25f..9c790c6 100644
--- a/src/southbridge/amd/pi/hudson/Makefile.inc
+++ b/src/southbridge/amd/pi/hudson/Makefile.inc
@@ -206,7 +206,7 @@ $(obj)/amdfw.rom:	$(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \
 			$(AMDFWTOOL)
 	rm -f $@
 	@printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
-	$(AMDFWTOOL) \
+	valgrind $(AMDFWTOOL) \
 		$(OPT_HUDSON_XHCI_FWM_FILE) \
 		$(OPT_HUDSON_IMC_FWM_FILE) \
 		$(OPT_HUDSON_GEC_FWM_FILE) \