[coreboot-gerrit] New patch to review for coreboot: util/lint: add check for auto-included headers

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Nov 30 18:30:00 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17658

-gerrit

commit 4f6ddcc3e7f0a1829132e3ea2688a41a90521993
Author: Martin Roth <martinroth at google.com>
Date:   Wed Nov 30 10:29:39 2016 -0700

    util/lint: add check for auto-included headers
    
    Since we've removed them from the tree, add a check to keep them out.
    
    Change-Id: I2995da765fee8796a297963d54a1c34f56376efe
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/lint/lint-stable-019-header-files | 35 ++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/util/lint/lint-stable-019-header-files b/util/lint/lint-stable-019-header-files
new file mode 100755
index 0000000..66bf580
--- /dev/null
+++ b/util/lint/lint-stable-019-header-files
@@ -0,0 +1,35 @@
+#!/bin/sh
+# This file is part of the coreboot project.
+#
+# Copyright (C) 2016 Google Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# DESCR: Check for auto-included headers
+
+LC_ALL=C export LC_ALL
+
+INCLUDED_DIRS='^src/'
+EXCLUDED_FILES='src/include/kconfig.h'
+
+HEADER_FILES="k*config rules"
+
+# Use git grep if the code is in a git repo, otherwise use grep.
+if [ -n "$(command -v git)" ] && [ -d .git ]; then
+	GREP_FILES="git grep -n"
+else
+	GREP_FILES="grep -rn"
+fi
+
+for header in $HEADER_FILES; do
+	${GREP_FILES} "#\s*include\s\+[\"<]\s*${header}\.h\s*[\">]" | \
+		grep "$INCLUDED_DIRS" | \
+		grep -v "$EXCLUDED_FILES"; \
+done
\ No newline at end of file



More information about the coreboot-gerrit mailing list