[coreboot-gerrit] Patch set updated for coreboot: sb/intel/lynxpoint: add missing I2C ACPI SSCN/FMCN methods

Matt DeVillier (matt.devillier@gmail.com) gerrit at coreboot.org
Wed Nov 30 16:47:41 CET 2016


Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17620

-gerrit

commit fedf45a74fa34b8dda7243ebc92426e30497e1d7
Author: Prabal Saha <coolstarorganization at gmail.com>
Date:   Thu Jul 14 12:34:33 2016 -0700

    sb/intel/lynxpoint: add missing I2C ACPI SSCN/FMCN methods
    
    The SSCN and FMCN methods provide the optimal HCNT/LCNT timing values to
    the driver, and are necessary when using I2C devices (eg, trackpad and
    touchscreen) in ACPI (vs PCI) mode.  Add these methods using the
    timing values from Broadwell, which work for Haswell/Lynxpoint as well.
    
    TEST: build google/peppy with trackpad/touchscreen devices in ACPI mode,
    observe proper operation under Windows [8.1/10] and Linux [Mint 18]
    
    Change-Id: I25f07ac474b041358315530e5f391bb33d9c4d04
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
 src/southbridge/intel/lynxpoint/acpi/serialio.asl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
index 930a8ee..e8e81c3 100644
--- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
@@ -165,6 +165,9 @@ Device (I2C0)
 	Name (_UID, 1)
 	Name (_ADR, 0x00150001)
 
+	Name (SSCN, Package () { 432, 507, 30 })
+	Name (FMCN, Package () { 72, 160, 30 })
+
 	// BAR0 is assigned during PCI enumeration and saved into NVS
 	Name (RBUF, ResourceTemplate ()
 	{
@@ -244,6 +247,9 @@ Device (I2C1)
 	Name (_UID, 1)
 	Name (_ADR, 0x00150002)
 
+	Name (SSCN, Package () { 432, 507, 30 })
+	Name (FMCN, Package () { 72, 160, 30 })
+
 	// BAR0 is assigned during PCI enumeration and saved into NVS
 	Name (RBUF, ResourceTemplate ()
 	{



More information about the coreboot-gerrit mailing list