[coreboot-gerrit] Patch set updated for coreboot: Makefile: Explicitly set GNU99 as C language standard

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Tue Nov 29 11:34:55 CET 2016


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17636

-gerrit

commit 2c2e4b0cb110e04b8b6cf3d8a8e10430b6859734
Author: Paul Menzel <pmenzel at molgen.mpg.de>
Date:   Tue Nov 29 10:30:44 2016 +0100

    Makefile: Explicitly set GNU99 as C language standard
    
    Different compiler versions use a different C language standard by
    default.
    
    GCC 4.9 uses GNU89 by default [1], while GCC 5.x uses GNU11 [2].
    
    So explicitly set it to GNU11 as discussed on the mailing list in thread
    *[RFC] Setting C99 by default* [3].
    
    [1] https://gcc.gnu.org/onlinedocs/gcc-4.9.4/gcc/C-Dialect-Options.html
    [2] https://gcc.gnu.org/onlinedocs/gcc-5.4.0/gcc/Standards.html
    [3] https://www.coreboot.org/pipermail/coreboot/2016-November/082541.html
    
    Change-Id: If1569618f8044925ff72dcf3543480b34d4f90d6
    Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index a193158..313914d 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -353,7 +353,7 @@ CPPFLAGS_common += -I$(VBOOT_SOURCE)/firmware/include
 CPPFLAGS_common += -include $(src)/include/kconfig.h
 CPPFLAGS_common += -I3rdparty
 
-CFLAGS_common += -pipe -g -nostdinc
+CFLAGS_common += -pipe -g -nostdinc -std=gnu99
 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes
 CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs
 CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time



More information about the coreboot-gerrit mailing list